feat(api): "broadcast" events to ALL channels #28487
Open
+37
−133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
vim.rpcnotify(0)
andrpcnotify(0)
are documented as follows:But that's not actually true. Channels must call
nvim_subscribe
to receive "broadcast" events, so it's actually "multicast".nvim_subscribe
is a source of confusion for users, because its name implies something more generally useful than what it does.Presumably the use-case of
nvim_subscribe
is to avoid "noise" on RPC channels not expected a broadcast notification, and potentially an error if the channel client reports an unknown event.Solution:
nvim_subscribe
/nvim_unsubscribe
.nvim_list_chans()
andnvim_get_chan_info()
to enumerate and filter the clients they want to target.rpcnotify()
.