Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): support vim.lsp.ListOpts for typehierarchy() #28483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(lsp): support vim.lsp.ListOpts for typehierarchy() #28483

wants to merge 1 commit into from
+118 −7

Conversation

tom-anders
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lsp label Apr 24, 2024
MariaSolOs
MariaSolOs reviewed Apr 27, 2024
View reviewed changes
runtime/doc/lsp.txt Outdated Show resolved Hide resolved
runtime/lua/vim/lsp/handlers.lua Outdated Show resolved Hide resolved
@tom-anders
Copy link
Contributor Author

Thanks for the review!

tom-anders added a commit to tom-anders/neovim that referenced this pull request Apr 29, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
8d59dce 
See neovim#28483 (comment)
MariaSolOs
MariaSolOs reviewed Apr 30, 2024
View reviewed changes
runtime/doc/lsp.txt Outdated Show resolved Hide resolved
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 1, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
e13987c 
See neovim#28483 (comment)
@tom-anders
Copy link
Contributor Author

Latest push fixes the lua warning about a shadowed parameter. Is there any way to disable the next.txt check? Or do we just ignore it?

@glepnir
Copy link
Member

glepnir commented May 1, 2024

news for feat change scope will skip it.

@tom-anders
Copy link
Contributor Author

news for feat change scope will skip it.

Right, but I think feat is appropiate here, isn't it? Or should this be a fix instead?

@github-actions github-actions bot requested a review from MariaSolOs May 1, 2024 08:06
lewis6991
lewis6991 reviewed May 1, 2024
View reviewed changes
runtime/lua/vim/lsp/handlers.lua Outdated Show resolved Hide resolved
runtime/lua/vim/lsp/handlers.lua Outdated Show resolved Hide resolved
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 3, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
84ff8ee 
See neovim#28483 (comment)
@tom-anders
Copy link
Contributor Author

Thanks for the review again!

I noticed that the loclist key to vim.lsp.ListOpts is not actually documented, but most LSP handlers still support it (e.g. references, documentSymbols, workspaceSymbol). There are some LSP handlers though that do not support it (declaration, definition, typeDefinition, implementation). Should I fix this in this PR as well, or maybe open a new one instead?

tom-anders added a commit to tom-anders/neovim that referenced this pull request May 3, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
1e28f74 
See neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 4, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
0dfc1cd 
See neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 4, 2024
@tom-anders
refactor(lsp): move repeated table construction into a variable
0a2aa80 
As suggested in neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 4, 2024
@tom-anders
refctor(lsp): use vim.cmd instead of api.nvim_command
de26496 
As suggested in
neovim#28483 (comment) and
neovim#28483 (comment)
@tom-anders tom-anders mentioned this pull request May 4, 2024
Merged
@tom-anders
Copy link
Contributor Author

All suggestions should be applied now, I moved the cleanup to a new PR: #28637

tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refactor(lsp): s/options/opts for parameters in vim.lsp.buf
4e5086a 
See neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refactor(lsp): move repeated table construction into a variable
56906fa 
As suggested in neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refctor(lsp): use vim.cmd instead of api.nvim_command
b9f9e24 
As suggested in
neovim#28483 (comment) and
neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refactor(lsp): move repeated table construction into a variable
6ffc209 
As suggested in neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refctor(lsp): use vim.cmd instead of api.nvim_command
76ad2b7 
As suggested in
neovim#28483 (comment) and
neovim#28483 (comment)
tom-anders added a commit to tom-anders/neovim that referenced this pull request May 7, 2024
@tom-anders
refactor(lsp): use vim.cmd instead of api.nvim_command
80d108e 
As suggested in
neovim#28483 (comment) and
neovim#28483 (comment)
@tom-anders
Copy link
Contributor Author

(rebased to fix conflicts caused by #28637)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wookayin wookayin wookayin left review comments

@justinmk justinmk justinmk left review comments

@lewis6991 lewis6991 lewis6991 left review comments

@famiu famiu famiu left review comments

@zeertzjq zeertzjq zeertzjq left review comments

@MariaSolOs MariaSolOs MariaSolOs left review comments

@folke folke Awaiting requested review from folke

@mfussenegger mfussenegger Awaiting requested review from mfussenegger

Assignees
No one assigned
Labels
ci:skip-news lsp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tom-anders @glepnir @wookayin @justinmk @lewis6991 @famiu @zeertzjq @MariaSolOs