fix(treesitter): clip end row early #28460
Conversation
| win_T *win = handle_get_window(window); | ||
| if (!win) { | ||
| return luaL_error(lstate, "invalid window"); |
There was a problem hiding this comment.
if it's a false positive (i.e. "can never happen"), assert() or abort() is fine too
There was a problem hiding this comment.
find_window_by_handle in the old version uses handle_get_window and does null check internally, and sets err in that case. So ERROR_SET(&err) in the old version implies win is non-null. But adding assert to that is somewhat redundant, so I replaced those stuff with handle_get_window and direct null check.
There was a problem hiding this comment.
It's redundant either way, because that warning was a false positive.
There was a problem hiding this comment.
Right, but I just wanted to reduce the noise from the warning
Also add some more argument checks.
tomtomjhj
changed the title
|
With the additional argument checks, I noticed a regression from #28417 and fixed it. cc @lewis6991 |
Problem: UINT32_MAX + 1 passed to vim._foldupdate. Solution: Clip the end row from treesitter asap to avoid such issues.
tomtomjhj
changed the title
Also add some more argument checks.
Ref: #28417 (comment)
cc @justinmk