feat(keymap)!: remove the default gs keymap

Problem: gs is a stupid mapping. Solution: Remove it!
neovim · Apr 24, 2024 · dae7e77 · dae7e77
1 parent a1550db
commit dae7e77
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/runtime/doc/news.txt b/runtime/doc/news.txt
@@ -140,6 +140,8 @@ The following changes may require adaptations in user config or plugins.
 • |nvim_open_win()| now blocks all autocommands when `noautocmd` is set,
  rather than just those from setting the `buffer` to display in the window.
 
+• Removed the default |gs| mapping.
+
 ==============================================================================
 BREAKING CHANGES IN HEAD *news-breaking-dev*
 

diff --git a/runtime/doc/various.txt b/runtime/doc/various.txt
@@ -515,16 +515,15 @@ gO Show a filetype-specific, navigable "outline" of the
 
  Currently works in |help| and |:Man| buffers.
 
-[N]gs *gs* *:sl* *:sleep*
+  *:sl* *:sleep*
 :[N]sl[eep] [N][m] Do nothing for [N] seconds, or [N] milliseconds if [m]
- was given. "gs" always uses seconds.
+ was given.
  Default is one second. >
  :sleep "sleep for one second
  :5sleep "sleep for five seconds
  :sleep 100m "sleep for 100 milliseconds
  10gs "sleep for ten seconds
 < Can be interrupted with CTRL-C.
- "gs" stands for "goto sleep".
  While sleeping the cursor is positioned in the text,
  if at a visible position.
  Queued messages are processed during the sleep.

diff --git a/runtime/doc/vim_diff.txt b/runtime/doc/vim_diff.txt
@@ -675,6 +675,8 @@ Highlight groups:
  \|setlocal winhighlight=StatusLine:StatusLineTerm,StatusLineNC:StatusLineTermNC
  \|else|setlocal winhighlight=|endif
 <
+Keymaps:
+ *gs*
 
 Options:
  *'aleph'* *'al'*

diff --git a/src/nvim/normal.c b/src/nvim/normal.c
@@ -5525,11 +5525,6 @@ static void nv_g_cmd(cmdarg_T *cap)
  nv_gomark(cap);
  break;
 
- // "gs": Goto sleep.
- case 's':
- do_sleep(cap->count1 * 1000);
- break;
-
  // "ga": Display the ascii value of the character under the
  // cursor. It is displayed in decimal, hex, and octal. -- webb
  case 'a':

diff --git a/test/old/testdir/test_sleep.vim b/test/old/testdir/test_sleep.vim
@@ -21,7 +21,7 @@ func! Test_sleep_bang()
  call s:assert_takes_longer('sl 50m', 50)
  call s:assert_takes_longer('sl! 50m', 50)
  call s:assert_takes_longer('1sleep', 1000)
- call s:assert_takes_longer('normal 1gs', 1000)
+ " call s:assert_takes_longer('normal 1gs', 1000)
 endfunc
 
 " vim: shiftwidth=2 sts=2 expandtab