improve comments in identify_levels #7777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlinnaka
commented
May 16, 2024
| @@ -310,22 +349,45 @@ mod tests { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn repro_identify_levels_bails_too_ealy_if_partitioned_keyspace_same_lsn() -> anyhow::Result<()> { | |||
| async fn test_disjoint_key_ranges_same_lsn() -> anyhow::Result<()> { | |||
There was a problem hiding this comment.
I'm not sure this test case still makes sense, given that the original problem it was written to demonstrate turned out to be a red herring. identify_levels() doesn't pay any attention to the key ranges, so testing with partitioned keyspace isn't that different from the existing tests.
3060 tests run: 2933 passed, 0 failed, 127 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
272416a at 2024-05-16T10:14:25.316Z :recycle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to PR #7775