Fix newlines in subject being shown with ?
#4298
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env->subject
with the original content, the previous code was replacingLF
characters with?
.format_string()
or similarenv->subject
intoenv->disp_subj
by replacing whitespace characters (iswspace()
) with a spaceI also tested with and without a
subjectrx
configuration, seems to be working as expected.There are also some side changes as discussed in #4276
#ifdef
not needed anymore inexpando/format.c
subjrx_apply_mods
frombool
tovoid
. Return value is not used anywhereSubject with newlines before the change:
Subject with newlines after the change:
Subject with non-printable characters or new line is shown with
?
#4276This is my first PR with C language related changes. Please tell me if there are any security or performance issues in my code.
Thank you @flatcap for giving me so much information in the issue.
Also please tell me if it is better to squash every commit into one at the end of the reviews.