index: fix cursor after new mail

[flatcap]

Update: I've fixed some problems, but the issue with <limit> remains.
Unfortunately, there isn't going to be a quick-fix for that.

---

When new mail arrives, the backends (maildir/imap) update the Mailbox and send notifications.
In the frontend, the Mailbox view (MView) observes these changes (mview_mailbox_observer()).
(MView was previously known as the Context)

Before we do anything that might affect the ordering of the Emails, remember the sequence number of the current Email.
Afterwards, search for the Email by the sequence number.

Fixes: #3544

[igor47]

didn't work for me for the specific issue i'm seeing:

1. apply a limit pattern
2. scroll to a middle message in the limited view
3. send myself a new email from a different account

i expect that i would remain where it was. instead, the message "New mail in this mailbox" is displayed, and the cursor position is lost/non-existent. pressing j then selects the first message in the mailbox/limited view.

[auouymous]

Why do the same unchanged commits keep getting force pushed?

[flatcap]

Ah! That's me git rebaseing my work branch over main so that I have the latest source.

[auouymous]

The latest push appears to fix the issue for me. I'm installing it on my main client and will let you know if it has any problems. Thank you!

[igor47]

does not fix it for me. i'm in a limited view, and when i get the notification "new mail in inbox", i still loose my current cursor position. my limited view did not include the new message. my configure (on debian 11.6):

/configure --build=x86_64-linux-gnu --prefix=/usr {--includedir=${prefix}/include} {--mandir=${prefix}/share/man} {--infodir=${prefix}/share/info} --sysconfdir=/etc --localstatedir=/var --disable-silent-rules {--libdir=${prefix}/lib/x86_64-linux-gnu} {--libexecdir=${prefix}/lib/x86_64-linux-gnu} --disable-maintainer-mode --disable-dependency-tracking --mandir=/usr/share/man --libexecdir=/usr/libexec --with-mailpath=/var/mail --gpgme --lua --notmuch --with-ui --gnutls --idn --mixmaster --sasl --tokyocabinet --disable-doc --disable-nls

[flatcap]

Thanks for the feedback ❤️

I spent the day working on this and made some progress, but I'm not done yet.
The trouble is the Pager combined with limit.

There are eight test cases, combinations of:

• Index vs Pager
• Limit vs No limit
• Inotify enabled vs disabled

[auouymous]

Oh, using a limit breaks both index and pager by setting cursor to an invalid message, and closes pager. This happens for new messages inserted at top or bottom, matching or not matching the limit.

Using inotify.

[auouymous]

New patch fixed the broken cursor after receiving new mail, but pager is still closed when new mail arrives before or after the cursor when a limit is set. It also introduced some new bugs.

Closing pager or changing messages after any mail as arrived does not mark message as old. Switching to another message or opening and closing pager again will mark the message as old.

I think the messages are being marked as old in the UI but not in the backend, and a refresh switches them back to new. So the next two bugs might only happen when messages are new or recently marked as old with no other actions that could sync them to the backend.

Receiving mail while in index or pager causes all old messages to be marked as new, and shows "Mailbox was externally modified".

While in pager, receiving mail before the cursor marks current message as old, updates the index so current message shifts down one, and then marks current message as new.

[auouymous]

Why was this pushed to main in 2523464?

[auouymous]

@flatcap git revert 2523464c1d6b293dc5f512944ed84f96823c6c9d cleanly reverts the patch out of main branch (assuming it was accidentally pushed). The only difference is the double mview.h include that has since been removed.