npm packageを最新安定版に更新 #317
Merged
npm packageを最新安定版に更新 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 21.84% 21.85% +0.01%
==========================================
Files 242 240 -2
Lines 9742 9735 -7
Branches 302 300 -2
==========================================
Hits 2128 2128
+ Misses 7434 7429 -5
+ Partials 180 178 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#316
関連 URL
https://lgtm-cat-frontend-git-feature-issue316upgrade-c7a048-nekochans.vercel.app/
このPRで対応すること / このPRで対応しないこと
#316 に記載されている通りnpm packageを可能な限り安定版に更新する。
Storybook の URL もしくはスクリーンショット
UI変更は発生していないのでなし
変更点概要
タイトルの通り。
ESLintは9系に上げてしまうとflat configがデフォルトとなり動作しないPluginが多数出てくるので8系に留めている。
一部のPluginは以下に対応状況が記載されている。少なくともここにあるPluginが全て9系に対応するまではESLintの9系は利用することが出来ない。
eslint/eslint#18391
msw-storybook-addonは安定版になったので2.0.0にアップグレード。設定の書き方が多少変わっているので https://zenn.dev/link/comments/32d483bf8305c3 にコメントを追加している。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
特になし