Cli #769
Closed
Cli #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-added cli directory -wrapped run in other function -implement neodoc, readJSON using fs-extra
-have NOT tested properly yet
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/neherlab/covid19-scenarios/qd2yr5gj3 |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * | ||
| * @param inputFilename The path to the file. | ||
| */ | ||
| function getSeverity(inputFilename: string | undefined) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| * @param name The age distribution name to use if no file is | ||
| * specified. | ||
| */ | ||
| function getAge(inputFilename: string | undefined, name: string) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit 6f7d256 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues and PRs
So far based on issue Introduce CLI and NPM package #663, we have begun
-Added cli/ directory (and changed package.json to reflect that)
-Added the neodoc parser
-Wrapped run() in an exportable function
-Read severity and age distribution json files instead of "import get*" statements
-^and doing the above with fs-extra
-Switching console.log to console.info/warn
Description
Impacted Areas in the application
Testing