Changed overflow: visible to overflow: hidden for hr element #861
Conversation
| @@ -53,7 +53,7 @@ h1 { | |||
| hr { | |||
| box-sizing: content-box; /* 1 */ | |||
| height: 0; /* 1 */ | |||
| overflow: visible; /* 2 */ | |||
| overflow: hidden; /* 2 */ | |||
There was a problem hiding this comment.
With this change the comment on line number 50 is now incorrect.
There was a problem hiding this comment.
you are right, I need to look into more detail
There was a problem hiding this comment.
Fixed the comment. Hope it is ok now :)
There was a problem hiding this comment.
Looking at the comment it would appear that Edge and IE were following spec and all other browsers weren't. So your change to the comment is still not accurate.
I'm not a maintainer so I don't know what the full expectations are for this, but for me personally I would expect the comment to reference the browsers that show overflow. This requires testing. If there are no browsers that are still showing overflow then the code change should be to remove the lines, not to change the value to "hidden". If there are still browsers showing overflow then it would be good to have that list so that eventually the code can be removed from this repo when they all follow spec.
There was a problem hiding this comment.
Adding this to my normalize in https://github.com/garrettw/vitals until I know it's not needed anymore.
|
Do you have a link to the spec? |
This is the link to the spec: https://html.spec.whatwg.org/multipage/rendering.html#the-hr-element-2 |
|
fixes #860 |
Applied the expected overflow value for hr element, accordingly to HTML5 spec