Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert the removal of SVG overflow:hidden, still needed for IE #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbenjamin
Copy link

The overflow: hidden rule for SVG images was removed in this commit
004d58b
The comment for this commit states:

Drop support for older browsers: IE 9-, Android 4, Safari 7-.

This rule is still necessary for supported versions of IE (10/11), so it shouldn't have been removed. This PR brings it back.

@jakob-e
Copy link

jakob-e commented Aug 18, 2020

Please note that sometimes overflow visible is desirable
https://twitter.com/JoshWComeau/status/1288606220304158721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants