Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forward auth when using custom cert #2479

Merged
merged 2 commits into from
May 23, 2024
Merged

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented May 21, 2024

Reference Issues or PRs

Fixes #2478 for existing certs (though it doesn't fix traefik's default self-signed cert)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally? Worked great for me
  • Did you add new tests?

Any other comments?

Copy link
Member

@marcelovilla marcelovilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis 🚀 !

@Adam-D-Lewis Adam-D-Lewis merged commit fb3bbd3 into develop May 23, 2024
26 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the forwardauth-custom-cert branch May 23, 2024 19:31
aktech pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[BUG] - Service Unavailable - Forwardauth doesn't work for self-signed certificates or custom certificates
3 participants