Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cloud provider deployment status badges to README.md #2407

Merged
merged 8 commits into from
May 31, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Apr 17, 2024

Reference Issues or PRs

You can see the new badges at https://github.com/nebari-dev/nebari/tree/depl-badges

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis added this to the Nebari Core Team - Docs milestone Apr 17, 2024
@Adam-D-Lewis Adam-D-Lewis self-assigned this Apr 18, 2024
@Adam-D-Lewis
Copy link
Member Author

Ready for review!

@viniciusdc
Copy link
Contributor

viniciusdc commented May 31, 2024

This is nice, thanks, @Adam-D-Lewis. I don't see any problems with integrating this right away, but I am curious if we want to first make the DO and Azure tests pass again.

Also, I noticed that the badge for DO says GCP in there because our DO tests have the same name as the GCP one in the workflow file 🤣

name: test-gcp-integration

@Adam-D-Lewis
Copy link
Member Author

Also, I noticed that the badge for DO says GCP in there because our DO tests have the same name as the GCP one in the workflow file 🤣

This PR will fix that naming issue. I think it'll only show up on that preview page after merge though.

@Adam-D-Lewis
Copy link
Member Author

This is nice, thanks, @Adam-D-Lewis. I don't see any problems with integrating this right away, but I am curious if we want to first make the DO and Azure tests pass again.

I say we merge without fixing. It'll give us motivation to fix those others soon.

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks @Adam-D-Lewis

@viniciusdc viniciusdc merged commit 2bac8aa into develop May 31, 2024
4 checks passed
@viniciusdc viniciusdc deleted the depl-badges branch May 31, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants