Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #1572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix typo #1572

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 30, 2023

Description

Make sure the PR is against the develop branch (see Contributing).

Make sure to set the corresponding milestone in the PR.

Please include a summary of the change(s) and which issue(s) it addresses. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (967ec54) 20.52% compared to head (7a91922) 20.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1572   +/-   ##
=======================================
  Coverage   20.52%   20.52%           
=======================================
  Files         384      384           
  Lines       13038    13038           
=======================================
  Hits         2676     2676           
  Misses      10362    10362           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 30, 2023

Python 3.6, 3.7, and 3.8 are expected below but these versions of Python are no longer tested so it is currently impossible to get a ✅ test even when correcting a simple typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant