Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/661 Azure specific resource group #1542

Closed

Conversation

Looyyd
Copy link

@Looyyd Looyyd commented Jun 21, 2023

Description

Allows to add the flag --resource-group "RG_NAME" to only scan the specified resource group in Azure.

This is achieved by passing the value of the flag up the abstractions until the facade creation. Then when resources are fetched the Facade classes check if self.resource_group is set, and if it is, it only fetches from that resource group using the appropriate APIs (either list_by_resource_group(resource_group_name=self.resource_group) or list(resource_group_name=self.resource_group) ).
Not sure if this is the best place to put it, let me know if you want refactoring.

I tested it on resources that I spawned up and it worked, I didn't see any existing relevant test suites for Azure.

Didn't modify Facade for AAD, RBAC and security center since those checks are inherently subscription level checks.

Fixes #661

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant