Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new common CLI flag to allow custom rules folders #1489

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

gillg
Copy link

@gillg gillg commented Dec 13, 2022

Description

This change allows to use a new CLI argument wich wake up an existing pre-coded feature to allow a user to specify multiple custom rules folders.

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@liyun-li liyun-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not functional dude. There is no code for processing rule_dirs.

@gillg
Copy link
Author

gillg commented Jun 6, 2023

This change is not functional dude. There is no code for processing rule_dirs.

Sorry but I don't understand.
I'm running scountsuite sucessfully with that code...

rule_dirs is used in __main__ line 166 in _run and 315 in new Ruleset(...) where it was already supported but just dormant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants