Adress review comments

README.md

@@ -33,7 +33,7 @@ You need configuration files. Check [our example repository](https://github.com/
 git clone https://github.com/nbiederbeck/lst-analysis-config.git ../lst-analysis-config
 ```
 
-You need snakemake and astropy installed. If you do not have that, you can create an enviroment with only snakemake like this:
+You need snakemake and astropy installed. If you do not have that, you can create an enviroment with only these packages like this:
 
 ```
 mamba env create -f workflow/envs/snakemake.yml

scripts/calc_flux_points.py

@@ -6,11 +6,9 @@
 
 
 def select_timeframe(datasets, t_start, t_stop):
- if t_start or t_stop:
- t_start = Time(t_start, format="mjd") if t_start else datasets.gti.time_start[0]
- t_stop = Time(t_stop, format="mjd") if t_stop else datasets.gti.time_stop[-1]
- datasets = datasets.select_time(t_start, t_stop)
- return datasets
+ t_start = Time(t_start, format="mjd") if t_start else datasets.gti.time_start[0]
+ t_stop = Time(t_stop, format="mjd") if t_stop else datasets.gti.time_stop[-1]
+ return datasets.select_time(t_start, t_stop)
 
 
 def main( # noqa: PLR0913

workflow/Snakefile

@@ -56,7 +56,3 @@ rule all:
  dl3_plots,
  dl4_plots,
  irf_plots,
-
-
-localrules:
- link_paths,

workflow/envs/snakemake.yml

@@ -1,7 +1,6 @@
 name: snakemake
 channels:
- - bioconda
  - conda-forge
 dependencies:
- - snakemake
+ - bioconda::snakemake
  - astropy