Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support for s3:// prefixes #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mrmaddx2
Copy link

@mrmaddx2 mrmaddx2 commented Oct 10, 2023

Hey there! I use your image to build a local spark setup, and s3:// prefixes are hardcoded inside code that I prefer to do not touch :)
This PR making it possible to use s3:// prefixes along with s3a://

@naushadh
Copy link
Owner

Hey @mrmaddx2 , thanks for your PR. I enabled builds for you but then found main was broken due to some issues. I've since fixed them here: #5. Could you please rebase your PR? Will merge once it goes green.

@mrmaddx2
Copy link
Author

Hey @mrmaddx2 , thanks for your PR. I enabled builds for you but then found main was broken due to some issues. I've since fixed them here: #5. Could you please rebase your PR? Will merge once it goes green.

Done. Sorry for the delay.

@mrmaddx2
Copy link
Author

@naushadh could you please take another look?

@naushadh
Copy link
Owner

The build is now failing due to missing secrets

PR build vs main build

Turns out I need to make some changes to securely expose secrets to PR builds: https://iterative.ai/blog/testing-external-contributions-using-github-actions-secrets

This week is tight for me, but I can take a stab at the secrets workflow this weekend.

In the meantime, you could try setting the following secrets on your fork and rerun the build as a potential workaround until I sort out a proper fix on my end.

  • DOCKER_USER - your docker hub login username
  • DOCKER_PASS - your docker hub login token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants