Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0-preview.1 #1

Merged
merged 1 commit into from
May 21, 2024
Merged

Release 1.0.0-preview.1 #1

merged 1 commit into from
May 21, 2024

Conversation

mtmk
Copy link
Collaborator

@mtmk mtmk commented May 17, 2024

Initial release. Please review the entire codebase. We can create additional PRs if needed.

cc @mkobaly

@mtmk mtmk requested a review from caleblloyd May 17, 2024 15:04
@caleblloyd
Copy link

Gave it a quick read, will go back through it tomorrow also. This API caught my eye:

public void Sign(ReadOnlyMemory<byte> message, Memory<byte> signature)

Do you think it would be more natural to instead have it return the signature?

public Memory<byte> Sign(ReadOnlyMemory<byte> message)

@mtmk
Copy link
Collaborator Author

mtmk commented May 21, 2024

Gave it a quick read, will go back through it tomorrow also. This API caught my eye:

public void Sign(ReadOnlyMemory<byte> message, Memory<byte> signature)

Do you think it would be more natural to instead have it return the signature?

public Memory<byte> Sign(ReadOnlyMemory<byte> message)

the intention is to avoid memory allocations or at least give the opportunity to do so. in the future if we can update the underlying ed25519 functions we can also introduce Span versions as well.

Copy link

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, we could add more user-friendly extensions that allocate in the future if people seem to want them

@mtmk mtmk merged commit 567dd43 into main May 21, 2024
4 checks passed
@mtmk mtmk deleted the releaseing-1.0.0-preview.1 branch May 21, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants