Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ResumeAtRevision support to KV Watcher #491

Merged
merged 14 commits into from
Jun 6, 2024
Merged

Add ResumeAtRevision support to KV Watcher #491

merged 14 commits into from
Jun 6, 2024

Conversation

niklasfp
Copy link
Contributor

Resolves #478

@niklasfp
Copy link
Contributor Author

@mtmk I'm seeing some test flappers in Watcher_reconnect_with_history and Watcher_timeout_reconnect locally (also without my changes)

Machine: Mac M2 Pro arm64

@mtmk mtmk self-assigned this Apr 24, 2024
@mtmk
Copy link
Collaborator

mtmk commented Apr 24, 2024

@mtmk I'm seeing some test flappers in Watcher_reconnect_with_history and Watcher_timeout_reconnect locally (also without my changes)

Machine: Mac M2 Pro arm64

I'm not surprised. they're most stable on Linux at the moment. We also have #464 to deal with Windows flappers. we might open one for Mac too. I'm guessing it's mostly around managing the server process and sockets, but I might be wrong.

mtmk
mtmk approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you @niklasfp 👍

@mtmk mtmk requested a review from caleblloyd April 25, 2024 15:39
@niklasfp
Copy link
Contributor Author

niklasfp commented May 2, 2024

@mtmk I have not forgotten about this one, I'll get to it this weekend

@mtmk
Copy link
Collaborator

mtmk commented Jun 4, 2024

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

@niklasfp
Copy link
Contributor Author

niklasfp commented Jun 5, 2024

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

Omg thank u, and so sorry for not following up on this, life happened 🥲 I'll take a look today.

@mtmk
Copy link
Collaborator

mtmk commented Jun 5, 2024

@niklasfp, @caleblloyd just made the last bit of validation changes. Please feel free to make suggestion, especially for docs. Let me know if y'all happy with it then I can merge it ;)

Omg thank u, and so sorry for not following up on this, life happened 🥲 I'll take a look today.

thanks @niklasfp very kind of you 🙏 honestly, we really appreciate your contribution, you've done the hard work and I'm always happy to tie the loose ends when you don't have time 😅

caleblloyd
caleblloyd reviewed Jun 5, 2024
View reviewed changes
src/NATS.Client.KeyValueStore/INatsKVStore.cs Outdated Show resolved Hide resolved
src/NATS.Client.KeyValueStore/INatsKVStore.cs Outdated Show resolved Hide resolved
src/NATS.Client.KeyValueStore/INatsKVStore.cs Outdated Show resolved Hide resolved
src/NATS.Client.KeyValueStore/INatsKVStore.cs Outdated Show resolved Hide resolved
caleblloyd
caleblloyd approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@caleblloyd caleblloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit fc9e2ca into nats-io:main Jun 6, 2024
10 checks passed
mtmk added a commit that referenced this pull request Jun 11, 2024
@mtmk
Release 2.2.3
4432609 
* Add ResumeAtRevision support to KV Watcher (#491)
* prefer sub channel ReadAllAsync and rm SubAnchor (#507)
* Keep sub alive when reading channel (#506)
* Add overload for empty requests (#502)
@mtmk mtmk mentioned this pull request Jun 11, 2024
Merged
mtmk added a commit that referenced this pull request Jun 11, 2024
@mtmk
Release 2.2.3 (#515)
c7229c9 
* Add ResumeAtRevision support to KV Watcher (#491)
* prefer sub channel ReadAllAsync and rm SubAnchor (#507)
* Keep sub alive when reading channel (#506)
* Add overload for empty requests (#502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

@caleblloyd caleblloyd caleblloyd approved these changes

Assignees

@mtmk mtmk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KV ResumeAtRevision option for watches
3 participants
@niklasfp @mtmk @caleblloyd