-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KV ResumeAtRevision option for watches #478
Comments
@mtmk as per slack conversation, I'll like to give this one a shot. Initial idea: NatsKvOpts.cs
NatsKVWatcher.cs
And I was thinking about setting _sequenceStream = opts.ResumeAtRevision here https://github.com/nats-io/nats.net.v2/blob/main/src/NATS.Client.KeyValueStore/Internal/NatsKVWatcher.cs#L78 |
@niklasfp looking at this a bit closer I think it's good. Setting the _sequenceStream = opts.ResumeAtRevision in NatsKVWatcher.ctor should work since it will treacle down to the consumer create request down below and also should be updated as expected on reconnects. feel free to open a PR when you're ready and have time. thank you 💯 |
For future reference and history, setting the sequence in the ctor was not an option because of the way watchers gets re-created. |
ResumeAtRevision
option for watches nats-architecture-and-design#261The text was updated successfully, but these errors were encountered: