Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update walkthrough_setup.md #666

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vaibhavpatil123
Copy link

No description provided.

@gcolliso gcolliso requested a review from ripienaar April 22, 2024 15:15
@gcolliso
Copy link
Member

@ripienaar could you review the addition here, please?

@Echo-Head-Wall
Copy link
Contributor

Echo-Head-Wall commented May 1, 2024

@vaibhavpatil123 you misspelled nats as ants also your
echo "export PATH=$PATH:~/usr/local/Cellar/nats/0.1.4/bin" >> ~/.zshrc vi changes source ~/.zshrc
should be in the code block or at least a second separate one. i think having the return of running the command here is not useful as no other example has it and its not mac specific Edit: ( i dont have a mac but i asked a friend who has one to try it and they said that it just worked no need to export or append to zshrc so im kinda confused what this if for)

@vaibhavpatil123
Copy link
Author

@vaibhavpatil123 you misspelled nats as ants also your echo "export PATH=$PATH:~/usr/local/Cellar/nats/0.1.4/bin" >> ~/.zshrc vi changes source ~/.zshrc should be in the code block or at least a second separate one. i think having the return of running the command here is not useful as no other example has it and its not mac specific Edit: ( i dont have a mac but i asked a friend who has one to try it and they said that it just worked no need to export or append to zshrc so im kinda confused what this if for)

thanks for input changes are incorporated please review and approve it thanks

@Echo-Head-Wall
Copy link
Contributor

Echo-Head-Wall commented May 21, 2024

i still don't get why you're including the entire output of the command seems unneeded and a lot of bloat. also your steps are version specific and again are you sure for using brew on mac it is required to manually add path since as i mentioned before i had a friend check and it worked fine withought adding it to path manually and your markdown header tags break the flow

```
In the editor, add the following line at the end of the file:
```
export PATH=\$PATH:~/usr/local/Cellar/nats/0.1.4/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not neccesary, the reason you have to do this is because your homebrew setup is incorrect. Correctly install homebrew and this will just work

These paths are also very unusual and probably due to something that went wrong with your homebrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants