Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Tomasz Pietrek <[email protected]>
  • Loading branch information
Jarema committed May 13, 2024
1 parent e1753c1 commit dd4e6e0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion server/consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ type CreateConsumerRequest struct {
Stream string `json:"stream_name"`
Config ConsumerConfig `json:"config"`
Action ConsumerAction `json:"action"`
Pedantic bool `json:"pedantic"`
Pedantic bool `json:"pedantic,omitempty"`
}

type ConsumerAction int
Expand Down
4 changes: 2 additions & 2 deletions server/stream.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ import (
"github.com/nats-io/nuid"
)

// StreamRequest is used to create or update a stream.
type StreamRequest struct {
// StreamConfigRequest is used to create or update a stream.
type StreamConfigRequest struct {
StreamConfig
// This is not part of the StreamConfig, because its scoped to request,
// and not to the stream itself.
Expand Down

0 comments on commit dd4e6e0

Please sign in to comment.