This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
enhance: _merge fix #187
Open
enhance: _merge fix #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beraliv
commented
Mar 9, 2019
| import _merge from '../_internal/_merge' | ||
|
|
||
| export default curry3(function mergeWith(cb, result) { | ||
| export default _curry2(function mergeWith(cb, result) { |
There was a problem hiding this comment.
it works with 2+ arguments, so no need for curry3
Beraliv
commented
Mar 9, 2019
| @@ -2,10 +2,11 @@ import _curry3 from '../_internal/_curry3' | |||
| import _merge from '../_internal/_merge' | |||
|
|
|||
| export default _curry3(function mergeDeepWithKey(func, left, right) { | |||
| return _merge(left, right, function(l, r, key) { | |||
| function mergeDeepWithKeyStrategy(l, r, key) { | |||
There was a problem hiding this comment.
anonymous function cannot be optimised in size
Beraliv
commented
Mar 9, 2019
| @@ -2,9 +2,13 @@ import _curry3 from '../_internal/_curry3' | |||
| import _merge from '../_internal/_merge' | |||
|
|
|||
| export default _curry3(function mergeDeepWith(func, left, right) { | |||
| var cb = function(l, r) { | |||
| if (typeof l === 'object' && typeof r === 'object' && !Array.isArray(l)) return mergeDeepWith(func, l, r) | |||
| function mergeDeepWithStrategy(l, r) { | |||
There was a problem hiding this comment.
created name for better debugging
Beraliv
commented
Mar 9, 2019
| import mergeDeepLeft from '../mergeDeepLeft/mergeDeepLeft' | ||
| import _merge from '../_internal/_merge' | ||
|
|
||
| function mergeDeepRightStrategy(left, right) { |
There was a problem hiding this comment.
created name for better debugging
Beraliv
commented
Mar 9, 2019
| var cb = function(l, r) { | ||
| if (!Array.isArray(l) && typeof l === 'object' && typeof r === 'object') { | ||
| return mergeDeepLeft(l, r) | ||
| function mergeDeepLeftStrategy(left, right) { |
There was a problem hiding this comment.
created name for better debugging
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: