forbid confirmation_height_clear command when other node process is running #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemahieu
reviewed
Jul 11, 2022
| @@ -154,6 +155,8 @@ void nano_daemon::daemon::run (boost::filesystem::path const & data_path, nano:: | |||
| std::cout << "Voting with more than one representative can limit performance: " << voting << " representatives are configured" << std::endl; | |||
| } | |||
| node->start (); | |||
| boost::interprocess::named_mutex process_mutex (boost::interprocess::open_or_create, "nano_node_process"); | |||
| process_mutex.try_lock (); | |||
There was a problem hiding this comment.
This isn't checking the result of try_lock.
There was a problem hiding this comment.
Yeah it prevents from executing confirmation_height_clear command when other node process is running, not the other way.
Do you suggest to check the result of try_lock and exiting the node process if false?
I think it's too risky to check the mutex on node side due to possibility of mutex not being unlocked from previous run, for example when node process was killed. Then you wouldn't be able to run the node until you reboot the machine.
|
How would this work if there were more than one nano nodes running on machine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if other local node process is running utilizing named_mutex.
Issue: #3832