Report: Support max/min timestamp in report output #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces timestamps for special function calls that take
the minimum or maximum time.
With this capability, users can identify function calls that exhibit
unusual execution times and investigate the underlying reasons.
Example usage:
$ uftrace report -f total-min-ts,total-max-ts
Total min ts Total max ts Function
============ ============ ====================
12.009 h 12.009 h main
12.009 h 12.009 h printf
12.009 h 12.009 h __monstartup
12.009 h 12.009 h __cxa_atexit
Resolves: namhyung#1898
Signed-off-by: Hanyu Cui <[email protected]>
namhyung
reviewed
May 14, 2024
| REPORT_F_SELF_TIME_MAX, | ||
| REPORT_F_SELF_TIME_MAX_TS, |
There was a problem hiding this comment.
Adding new fields in the middle created some problems. Let's add them after the STDV fields.
| static void print_##_func(struct field_data *fd) \ | ||
| { \ | ||
| struct uftrace_report_node *node = fd->arg; \ | ||
| print_time_unit_padding(node->_field, 2); \ |
There was a problem hiding this comment.
Nop, timestamp should not be printed using print_time_unit(). Please add something similar to print_timestamp() in cmds/replay.c file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @namhyung
According to the requirements in the issue #1898 , I have currently made a simple addition of four optional output fields: total-min-ts, total-max-ts, self-min-ts, and self-max-ts. Due to the longer field names, I have adjusted the output format accordingly.
The current problem is that the timestamp's starting time seems too early, resulting in excessively large timestamps. Additionally, the code hasn't passed through the pipeline yet, so I will further investigate the problem.
I hope you could review my work and provide valuable feedback.
Thank you very much!