Fix linking of GLEW library #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindGLEW.cmake Module silently tries to include glew-config.cmake. If it succeeds, then it stop and return to the caller. However, glew-config.cmake only sets GLEW::GLEW, resulting in missing glew shared library at link time. Credits to Eduardo Suarez-Santana for discovering the build error and providing the fix. https://gitlab.exherbo.org/DanySpin97/danyspin97-exheres/-/issues/2
Shawn8901
pushed a commit
to Shawn8901/nixpkgs
that referenced
this pull request
Feb 17, 2023
FindGLEW.cmake Module silently tries to include glew-config.cmake. If it succeeds, then it stop and return to the caller. However, glew-config.cmake only sets GLEW::GLEW, resulting in missing glew shared library at link time. References: * naelstrof/slop#135 * https://gitlab.exherbo.org/DanySpin97/danyspin97-exheres/-/issues/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindGLEW.cmake Module silently tries to include glew-config.cmake.
If it succeeds, then it stop and return to the caller.
However, glew-config.cmake only sets GLEW::GLEW, resulting in
missing glew shared library at link time.
I've also fixed the inclusion of its header but I am not 100% sure it is correct (cmake docs don't talk about imported target in
include_directories).Credits to Eduardo Suarez-Santana for discovering the build error and providing the fix.
https://gitlab.exherbo.org/DanySpin97/danyspin97-exheres/-/issues/2