Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LinkedIn Node): Upgrade LinkedIn API version #9307

Merged
merged 3 commits into from May 8, 2024

Conversation

floryn90
Copy link
Contributor

@floryn90 floryn90 commented May 4, 2024

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Upgrade LinkedIn API version

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

#9306

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

@Joffcom
Copy link
Member

Joffcom commented May 4, 2024

Thanks for the PR @floryn90, I will close the issue as we don't need both.

Do you know if this change alters the output or if the requests also need to change?

@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels May 4, 2024
@floryn90
Copy link
Contributor Author

floryn90 commented May 5, 2024

Thanks for the PR @floryn90, I will close the issue as we don't need both.

Do you know if this change alters the output or if the requests also need to change?

hi @Joffcom,
I found that now, in order to upload the image, you need to specify also the image's Content-Type Header otherwise the request will produce a 400 HTTP error.

@Joffcom Joffcom changed the title Upgrade LinkedIn API version feat(LinkedIn Node): Upgrade LinkedIn API version May 8, 2024
@Joffcom
Copy link
Member

Joffcom commented May 8, 2024

Thanks for the PR @floryn90, This will be in the next release 🙌🏻

@Joffcom Joffcom merged commit 3860077 into n8n-io:master May 8, 2024
8 of 9 checks passed
@github-actions github-actions bot mentioned this pull request May 8, 2024
@janober
Copy link
Member

janober commented May 8, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Authored by a community member node/improvement New feature or request Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants