refactor(core): Rename ActiveWorkflowRunner to ActiveWorkflowManager (no-changelog)
#9280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
despairblue
requested changes
May 3, 2024
There was a problem hiding this comment.
I checked how much conflicts this would cause with feature/rbac, but it's manageable.
I found some variables that still mention Runner. I saw that you renamed most of the others to be called ...Manager, maybe we can rename the remaining ones as well to have this consistent. What do you think?
packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/PublicApi/v1/handlers/workflows/workflows.handler.ts
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing!
Happy to wait! I'll leave it up to you.
Fixed! |
despairblue
previously approved these changes
May 6, 2024
despairblue
approved these changes
May 6, 2024
1 flaky test on run #4874 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #9280 ↗︎
|
✅ All Cypress E2E specs passed |
This comment was marked as resolved.
This comment was marked as resolved.
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have
WorkflowService,ExecutionService,WorkflowExecutionService,WorkflowRunner,ActiveExecutions,ActiveWorkflows, andActiveWorkflowRunner- the overlap in semantics and responsibilities makes the workflow execution lifecycle hard to follow.This PR is the first of a series:
ActiveWorkflowRunnertoActiveWorkflowManagerWorkflowExecutionServicewithWorkflowRunnerasRunnerServiceExecutionServicetoRunnerService