feat(core): Warn on unknown N8N env vars
#9279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
krynble
reviewed
May 6, 2024
despairblue
reviewed
May 6, 2024
Comment on lines
+18
to
+30
| const traverse = (obj: Record<string, unknown>) => { | ||
| for (const key in obj) { | ||
| const value = obj[key] as Record<string, unknown> | string; | ||
|
|
||
| if (typeof value === 'object') { | ||
| traverse(value); | ||
| } else if (typeof value === 'string' && key === 'env') { | ||
| envVars.push(value); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| traverse(schema); |
There was a problem hiding this comment.
Why do we create a function and call it right away? Would something break if we lifted the body of traverse into findSchemaEnvVars' body?
|
Seeing now that we haven't been consistent in prefixing our envs with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://n8nio.slack.com/archives/C062YRE7EG4/p1714479857216859?thread_ts=1714470342.955679&cid=C062YRE7EG4