Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix potential GitHub Actions smells #9245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix potential GitHub Actions smells #9245

wants to merge 1 commit into from
+21 −4

Conversation

ceddy4395
Copy link

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Avoid executing scheduled workflows on forks
  • Avoid uploading artifacts on forks
  • Stop running workflows when there is a newer commit in branch
  • Stop running workflows when there is a newer commit in PR

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@ceddy4395
Fix gha smells:
a484376 
- Avoid executing  scheduled workflows on forks
- Avoid uploading artifacts on forks
- Stop running workflows when there is a newer commit in branch
- Stop running workflows when there is a newer commit in PR
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@n8n-assistant n8n-assistant bot added the community Authored by a community member label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Authored by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ceddy4395 @CLAassistant