Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(RSS Feed Trigger Node): Use newest date instead of first item for new items #9182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(RSS Feed Trigger Node): Use newest date instead of first item for new items #9182

wants to merge 1 commit into from
+2 −1

Conversation

meownoid
Copy link

Summary

Describe what the PR does and how to test. Photos and videos are recommended.

This PR fixes issue described in the #8856 when RSS Feeds where latest element is not last in the feed leads to infinitely repeating triggers. Original trigger node does not have tests and I'm not sure how to create one from scratch.

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

#8856

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

@CLAassistant
Copy link

CLAassistant commented Apr 20, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@Joffcom Joffcom changed the title Use maximum date instead of last one in RSS Feed Trigger Fix(RSS Feed Trigger Node): Use newest date instead of first item for new items Apr 22, 2024
@Joffcom Joffcom changed the title Fix(RSS Feed Trigger Node): Use newest date instead of first item for new items fix(RSS Feed Trigger Node): Use newest date instead of first item for new items Apr 22, 2024
@n8n-assistant n8n-assistant bot added community Authored by a community member node/improvement New feature or request labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joffcom Joffcom Joffcom approved these changes

Assignees
No one assigned
Labels
community Authored by a community member node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meownoid @CLAassistant @Joffcom