Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1alpha #232

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open

v1alpha #232

wants to merge 57 commits into from

Conversation

h-otter
Copy link
Member

@h-otter h-otter commented Sep 21, 2019

What / 変更点

  • 同期APIから非同期APIに変更
  • 認証機能などIAM機能の追加
  • golangのcanonical importを利用 github.com/n0stack/n0stack -> n0sta.ac/n0stack

Why / 変更した理由

How (Optional) / 概要

How affect / 影響範囲


func (a *ProjectAPI) AddProjectMembership(ctx context.Context, req *piam.AddProjectMembershipRequest) (*piam.Project, error) {
if req.Membership == piam.ProjectMembership_PROJECT_MEMBERSHIP_UNSPECIFIED {
return nil, stdapi.ValidationError("member_ship", "necessary to specify any membership")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

membership で一語

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、typoです
ありがとうございます

@h-otter h-otter added this to the v1alpha milestone Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants