Implement virtualmachine's hard-reboot (hard-reset) operation #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-otter
reviewed
Feb 20, 2019
n0core/pkg/driver/qemu/command.go
Outdated
| } | ||
|
|
||
| return q.Boot() | ||
| return q.m.SystemReset() |
There was a problem hiding this comment.
起動 -> 起動は Systemreser() でいいとして、未起動 -> 起動 もrebootとしては正常に動作してもいいのではと思ったときに書いたものだった
どっちがいいんだろう
ライブラリを使う側がそういうのは制御するべきなような気もする
There was a problem hiding this comment.
どちらでも良い気がしますが、この操作をしたあとに電源が入っていることをユーザは期待しそうなので起動にしたほうがよいですかね
h-otter
reviewed
Feb 20, 2019
h-otter
reviewed
Feb 20, 2019
| } | ||
| } else { | ||
| // TODO: soft-reboot のやり方を調べる | ||
| return nil, grpcutil.WrapGrpcErrorf(codes.Unimplemented, "") |
kyontan
force-pushed
the
implement-hard-reboot
branch
from
ab4cf82
to
482f4e6
Compare
|
手が空いたときに見ます 🙇 |
|
すまん、ついでにcliにサブコマンドを生やしてくれませんか テストがめんどくさいし、結局必要があると思うので |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / 変更点
RebootVirtualMachineを実装したfunc (q Qemu) HardReset() errorについてはq.m. SystemReset()でリセット後に起動してくるため、Boot()を呼ばないよう修正Why / 変更した理由
未実装だったため
How (Optional) / 概要
How affect / 影響範囲