Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leading and trailing quotation marks in DataDir and filename to allow spaces in DbDir #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abagrov
Copy link

@abagrov abagrov commented Feb 6, 2024

Fix for #29

@mysticmind
Copy link
Owner

@abagrov Unit tests are failing on non-windows. Besides just adding the path in double quotes doesn't seem to be helping. Did you test with a similar use case as in the issue details?

@abagrov
Copy link
Author

abagrov commented Feb 11, 2024

@mysticmind Yeah, i said a little wrong, this PR fixes only path with spaces. As far as i understood, problem with special character is coming from initdb and we cant do much with this. But we can handle path with spaces - i added few corrections and tests to PR.
BTW, this PR should fix spaces problem on non-windows environments too, but new tests are failing with permission denied error on non-windows environments, which seems not related to fixes. I didnt manage to solve this, so i added only windows condition for these tests as a workaround. So lets assume this PR fixes windows environment at least 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants