fix lint issues

Signed-off-by: Jeeva Kandasamy <[email protected]>
mycontroller-org · Mar 30, 2024 · 15d8427 · 15d8427
1 parent 546d5cd
commit 15d8427
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -13,7 +13,7 @@ jobs:
  - uses: actions/checkout@v2
  - uses: actions/setup-go@v2
  with:
- go-version: ^1.20
+ go-version: ^1.21
 
  - name: golangci-lint
  uses: golangci/golangci-lint-action@v2

diff --git a/.github/workflows/publish_executables.yaml b/.github/workflows/publish_executables.yaml
@@ -14,7 +14,7 @@ jobs:
 
  - uses: actions/setup-go@v2
  with:
- go-version: ^1.20
+ go-version: ^1.21
 
  - name: Cache go modules
  uses: actions/cache@v2

diff --git a/cmd/sub/root.go b/cmd/sub/root.go
@@ -54,7 +54,11 @@ var rootCmd = &cobra.Command{
  // start service
  ctx := context.Background()
  toMqtt := helper.ToMqtt{}
- toMqtt.Start(ctx, cfg)
+ err = toMqtt.Start(ctx, cfg)
+ if err != nil {
+ logger.Fatal("error on starting the service", zap.Error(err))
+ }
+
  },
 }
 

diff --git a/pkg/service/adapter/service.go b/pkg/service/adapter/service.go
@@ -141,9 +141,10 @@ func (s *Service) mqttMessageProcessor(item interface{}) {
  if err != nil {
  s.logger.Error("error on writing a message to mqtt", zap.String("adapterName", s.adapterConfig.Name), zap.String("provider", s.adapterConfig.Provider), zap.Error(err))
  }
- } else {
- // TODO: this message will be dropped, needs to handle this message
  }
+ // else {
+ // TODO: this message will be dropped, needs to handle this message
+ // }
 }
 
 func (s *Service) sourceMessageProcessor(item interface{}) {
@@ -165,9 +166,10 @@ func (s *Service) sourceMessageProcessor(item interface{}) {
  if err != nil {
  s.logger.Error("error on writing a message to source device", zap.String("adapterName", s.adapterConfig.Name), zap.String("provider", s.adapterConfig.Provider), zap.Error(err))
  }
- } else {
- // TODO: this message will be dropped, needs to handle this message
  }
+ // else {
+ // TODO: this message will be dropped, needs to handle this message
+ // }
 }
 
 func (s *Service) onMqttMessage(message *types.Message) {