Fix stem direction on drumset XML import #22908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
May 20, 2024
mike-spa
reviewed
May 20, 2024
| static void xmlSetDrumsetPitch(Note* note, const Chord* const chord, const Staff* const staff, int step, int octave, | ||
| NoteHeadGroup headGroup, const Instrument* const instrument) | ||
| static void xmlSetDrumsetPitch(Note* note, Chord* const chord, const Staff* const staff, int step, int octave, | ||
| NoteHeadGroup headGroup, DirectionV& stemDir, const Instrument* const instrument) |
There was a problem hiding this comment.
Is it really necessary to have all these const-pointer to const-object definitions? Can't it just be const Chord* const Staff* const Instrument*?
mike-spa
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: see images - an issue with incorrect stem directions after importing drumkit parts from an XML file
