Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicXML: mark linked staves when writing staff-details #22614

Merged
merged 3 commits into from
May 21, 2024

Conversation

rettinghaus
Copy link
Contributor

@rettinghaus rettinghaus commented Apr 28, 2024

Small addition to MusicXML export for marking linked staves as "alternate".

See https://www.w3.org/2021/06/musicxml40/musicxml-reference/examples/staff-type-element/

@cbjeukendrup
Copy link
Contributor

Two things:

  • Should it be added to all linked staves, or to all except the "original" one?
  • Strictly speaking, this page https://www.w3.org/2021/06/musicxml40/musicxml-reference/data-types/staff-type/ mentions: "shares the same music as the prior staff", which suggests that the alternative option is not accurate when there is a non-linked staff between two linked staves. What to do with this? Should we ignore it?

@rettinghaus rettinghaus marked this pull request as draft April 28, 2024 20:29
@rettinghaus
Copy link
Contributor Author

@cbjeukendrup Not to the "original" one, and only to directly following ones. Yes, it needs another check. Working on it.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 28, 2024
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 29, 2024
@rettinghaus rettinghaus marked this pull request as ready for review April 29, 2024 08:56
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 29, 2024
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 29, 2024

You may want to proactively fix the currently unused harmony7 unit test, see Jojo-Schmitz#451. It will become active as part of #16904

@RomanPudashkin RomanPudashkin merged commit 158f3e7 into musescore:master May 21, 2024
11 checks passed
@rettinghaus rettinghaus deleted the xml/linkedSatff branch May 21, 2024 14:26
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants