Use impure to mark hasNext in iterator (#78)

munusphp · Sep 19, 2023 · 6c0f492 · 6c0f492
1 parent e5c7193
commit 6c0f492
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -17,11 +17,6 @@ parameters:
  count: 1
  path: src/Collection/Stream/Collectors.php
 
- -
- message: "#Unreachable statement - code above always terminates.#"
- count: 1
- path: src/Collection/Iterator.php
-
  -
  message: "#Template type T of method#"
  count: 6

diff --git a/src/Collection/Iterator.php b/src/Collection/Iterator.php
@@ -72,6 +72,9 @@ public static function fromIterable(iterable $elements): self
  return new ArrayIterator($elements);
  }
 
+ /**
+ * @phpstan-impure
+ */
  public function hasNext(): bool
  {
  return !$this->current->isEmpty();
@@ -140,7 +143,7 @@ public function reduce(callable $operation)
  }
 
  $accumulator = $this->next();
- while ($this->hasNext()) { // @phpstan-ignore-line
+ while ($this->hasNext()) {
  $accumulator = $operation($accumulator, $this->next());
  }