Small correction - the constructor in Ruby is not called "init". #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thus, change the text to specify that Ruby calls its constructor `initialize`
|
This PR fixes #999, which I noticed after creating the PR. |
icecream17
reviewed
Feb 6, 2022
| @@ -1062,7 +1062,8 @@ new LoxInstance object. | |||
| We'll do the remaining part -- user-defined initialization -- now. Languages | |||
| have a variety of notations for the chunk of code that sets up a new object for | |||
| a class. C++, Java, and C# use a method whose name matches the class name. Ruby | |||
| and Python call it `init()`. The latter is nice and short, so we'll do that. | |||
| calls it `initialize()` and Python calls it `init()`. The latter is nice and | |||
There was a problem hiding this comment.
Technically python uses __init__
Looking at https://en.wikipedia.org/wiki/Comparison_of_programming_languages_(object-oriented_programming)#Constructors_and_destructors it seems like Swift uses init so that works
|
@icecream17 - you are absolutely correct. This PR is only about fixing the Ruby initializer name, and nothing else. I just wanted to avoid mixing issues, so I left all the other names as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus, change the text to specify that Ruby calls its constructor
initialize