Update Electron to version 30 #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
update-to-electron-30
branch
2 times, most recently
from
0c6f426
to
fcb115d
Compare
dlon
force-pushed
the
update-to-electron-30
branch
from
fcb115d
to
03f59e4
Compare
raksooo
reviewed
May 16, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dlon)
test/test-manager/src/vm/qemu.rs line 26 at r2 (raw file):
const STDERR_LOG_LEVEL: log::Level = log::Level::Error; const STDOUT_LOG_LEVEL: log::Level = log::Level::Debug; const OBTAIN_IP_TIMEOUT: Duration = Duration::from_secs(180);
Is this related to the Electron upgrade?
dlon
force-pushed
the
update-to-electron-30
branch
from
4e74c8a
to
03f59e4
Compare
dlon
force-pushed
the
update-test-executable-pack
branch
2 times, most recently
from
48a8bf9
to
236c0a8
Compare
dlon
force-pushed
the
update-to-electron-30
branch
from
03f59e4
to
6f1d1fd
Compare
dlon
commented
May 16, 2024
There was a problem hiding this comment.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @raksooo)
test/test-manager/src/vm/qemu.rs line 26 at r2 (raw file):
Previously, raksooo (Oskar Nyberg) wrote…
Is this related to the Electron upgrade?
Only very indirectly. I've reverted it and fixed it in another PR.
raksooo
approved these changes
May 16, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the changelogs for versions 29 and 30:
https://github.com/electron/electron/releases/tag/v30.0.0
https://github.com/electron/electron/releases/tag/v29.0.0
Fix DES-867.
This change is