[website] Fix FlashCode position #42139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-42139--material-ui.netlify.app/ Bundle size report |
danilo-leal
reviewed
May 6, 2024
There was a problem hiding this comment.
Cool! Left a couple of remarks. I'm also touching on these components somewhat significantly at another PR (#38604). Lastly, I wonder if this is really a regression? It sounds too severe as it's non-functional and non-blocking—a bug rings as more reasonable.
| <Box | ||
| sx={{ | ||
| position: 'relative', | ||
| overflow: 'clip', |
There was a problem hiding this comment.
We still need overflow: clip here, otherwise:
| }} | ||
| > | ||
| <HighlightedCode copyButtonHidden plainStyle code={code} language="jsx" /> | ||
| <FlashCode startLine={startLine[index]} endLine={endLine[index]} sx={{ mx: 1 }} /> | ||
| <Box sx={{ position: 'relative' }}> |
There was a problem hiding this comment.
I'm curious why an extra DOM node here (as opposed to having position: 'relative' in the Frame.Info) is better than sx={{ mx: 1 }} in the FlashCode component?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick one I noticed
Before:
After:
