Merge pull request #123 from andrewnicols/fixPhpStanDetectedIssues

Fix incorrect class names

classes/local/skel/base.php

@@ -111,7 +111,6 @@ public function set_attribute(string $attribute, $value = true) {
  * Render the file contents.
  *
  * @param renderer_base $renderer
- * @return The file source code contents.
  */
  public function render($renderer) {
  $this->content = $this->normalize($renderer->render($this->get_template_name(), $this->get_template_data()));

classes/local/skel/external_function_file.php

@@ -34,7 +34,7 @@ class external_function_file extends php_single_file {
  public function generate_external_function_code(array $external): void {
 
  if (empty($this->data)) {
- throw new coding_exception('Skeleton data not set');
+ throw new \coding_exception('Skeleton data not set');
  }
 
  $this->set_attribute('has_extra_requirements');

classes/local/skel/lib_php_file.php

@@ -25,7 +25,7 @@
 
 namespace tool_pluginskel\local\skel;
 
-use tool_pluginskel\local\util\exception;
+use coding_exception;
 
 /**
  * Class representing the lib.php file.

classes/local/skel/locallib_php_file.php

@@ -25,6 +25,8 @@
 
 namespace tool_pluginskel\local\skel;
 
+use coding_exception;
+
 /**
  * Class representing the locallib.php file.
  *
@@ -45,7 +47,7 @@ class locallib_php_file extends php_library_file {
  public function add_event_callback($callback, $event) {
 
  if (empty($this->data)) {
- throw new exception('Skeleton data not set');
+ throw new coding_exception('Skeleton data not set');
  }
 
  if (empty($this->data['self'])) {

classes/local/skel/observer_file.php

@@ -25,6 +25,8 @@
 
 namespace tool_pluginskel\local\skel;
 
+use coding_exception;
+
 /**
  * Class representing a Moodle observer class file.
  *
@@ -41,11 +43,11 @@ class observer_file extends php_single_file {
  public function set_observer_name($name) {
 
  if (empty($this->data)) {
- throw new exception('Skeleton data not set');
+ throw new coding_exception('Skeleton data not set');
  }
 
  if (!empty($this->data['observer']['observer_name'])) {
- throw new exception("Observer: '$name' already set");
+ throw new coding_exception("Observer: '$name' already set");
  }
 
  $this->data['observer']['observer_name'] = $name;
@@ -60,7 +62,7 @@ public function set_observer_name($name) {
  public function add_event_callback($callback, $event) {
 
  if (empty($this->data)) {
- throw new exception('Skeleton data not set');
+ throw new coding_exception('Skeleton data not set');
  }
 
  if (empty($this->data['observer']['callbacks'])) {
@@ -78,7 +80,7 @@ public function add_event_callback($callback, $event) {
  public function set_file_namespace($namespace) {
 
  if (empty($this->data)) {
- throw new exception('Skeleton data not set');
+ throw new coding_exception('Skeleton data not set');
  }
 
  $this->data['observer']['namespace'] = 'namespace '.$namespace.';';

classes/local/skel/phpunit_test_file.php

@@ -25,7 +25,7 @@
 
 namespace tool_pluginskel\local\skel;
 
-use tool_pluginskel\local\util\exception;
+use coding_exception;
 
 /**
  * Class representing the phpunit test file.
@@ -34,14 +34,12 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class phpunit_test_file extends php_single_file {
-
  /**
  * Adds the classname of the class.
  *
  * @param string $classname
  */
  public function set_classname($classname) {
-
  if (empty($this->data)) {
  throw new coding_exception('Skeleton data not set');
  }