Use a JS only tail implementation #201

teid · 2020-03-21T17:14:38Z

In order to have the same behaviour between Linux and Windows (related to this issue: #197), I've switched to a lib that provide a JS only tail

This is still a work in progress, I still have to test it on Windows server, but I don't have it right now.

During a file rotation, we may loose couple of lines (until the retry). The native tail handle this in a better way though.
When we tail multiple files, tail has a syntax to display it:

test1.log sam. 21 mars 2020 17:54:08 CET
test1.log sam. 21 mars 2020 17:54:10 CET
test1.log sam. 21 mars 2020 17:54:11 CET
==> ../frontail/logs/test2.log <==
test2.log sam. 21 mars 2020 17:54:15 CET
test2.log sam. 21 mars 2020 17:55:04 CET
test2.log sam. 21 mars 2020 17:55:10 CET
test2.log sam. 21 mars 2020 17:55:12 CET
==> ../frontail/logs/test1.log <==
test1.log sam. 21 mars 2020 17:55:14 CET
test1.log sam. 21 mars 2020 17:55:17 CET
test1.log sam. 21 mars 2020 17:55:38 CET
test1.log sam. 21 mars 2020 17:55:47 CET

With this implementation, it's difficult to reproduce the same, so I changed the output (also, I allowed stdin to be followed along with other files):

../frontail/logs/test1.log - test1.log sam. 21 mars 2020 17:54:08 CET
../frontail/logs/test1.log - test1.log sam. 21 mars 2020 17:54:10 CET
../frontail/logs/test1.log - test1.log sam. 21 mars 2020 17:54:11 CET
../frontail/logs/test2.log - test2.log sam. 21 mars 2020 17:54:15 CET
                     stdin - stdin.log sam. 21 mars 2020 17:54:19 CET
                     stdin - stdin.log sam. 21 mars 2020 17:54:59 CET
                     stdin - stdin.log sam. 21 mars 2020 17:55:01 CET
                     stdin - stdin.log sam. 21 mars 2020 17:55:02 CET
../frontail/logs/test2.log - test2.log sam. 21 mars 2020 17:55:10 CET
../frontail/logs/test2.log - test2.log sam. 21 mars 2020 17:55:12 CET
../frontail/logs/test1.log - test1.log sam. 21 mars 2020 17:55:17 CET

Let me know what do you think about it :)

teid · 2020-03-21T17:15:23Z

lib/tail.js

+ }
+});
+
+function readLastLinesIfPossible(path, onLineCb) {


I had to add this function, because the native tail does it. But the JS lib does not

lib/tail.js

test/tail.js

mthenw · 2020-03-31T18:19:50Z

@teid is it ready to be reviewed?

teid · 2020-04-01T19:42:43Z

Yes @mthenw, I validated that this change fixes the issue I had on the Windows server

kubawolanin · 2021-06-20T16:01:21Z

Does this look mergeable @mthenw?
For me branch with @teid's work (thank you!) is the only way allowing me to use frontail with multiple files on Windows server.
Cheers

teid commented Mar 21, 2020

View reviewed changes

lib/tail.js Outdated Show resolved Hide resolved

test/tail.js Outdated Show resolved Hide resolved

teid force-pushed the useJsTail branch 2 times, most recently from 680d9c9 to fc35ea6 Compare March 22, 2020 14:37

Use a full JS tail implementation

4ee667f

teid force-pushed the useJsTail branch from fc35ea6 to 4ee667f Compare April 1, 2020 19:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use a JS only tail implementation #201

Use a JS only tail implementation #201

teid commented Mar 21, 2020 •

edited

teid Mar 21, 2020

mthenw commented Mar 31, 2020

teid commented Apr 1, 2020

kubawolanin commented Jun 20, 2021

Use a JS only tail implementation #201

Are you sure you want to change the base?

Use a JS only tail implementation #201

Conversation

teid commented Mar 21, 2020 • edited

teid Mar 21, 2020

Choose a reason for hiding this comment

mthenw commented Mar 31, 2020

teid commented Apr 1, 2020

kubawolanin commented Jun 20, 2021

teid commented Mar 21, 2020 •

edited