Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (static-content-hosting): [example] code refresh #130

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ferantivero
Copy link
Contributor

@ferantivero ferantivero commented May 13, 2024

  • remove old code
  • add bicep to deploy Azure storage account
  • add static content
  • add devcontainer
  • add instructions to deploy content to a static website enabled storage account

Test E2E

image

@ferantivero ferantivero force-pushed the feature/205203_static-content-refresh branch 3 times, most recently from 5f7cfe0 to d711c37 Compare May 22, 2024 14:50
- set content-type
- cache-directives
- index is no longer static
- improve text as side task
@ferantivero ferantivero force-pushed the feature/205203_static-content-refresh branch from d711c37 to 657c904 Compare May 22, 2024 17:46
@ferantivero ferantivero marked this pull request as ready for review May 22, 2024 17:49
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few items here.

static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/README.md Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/bicep/main.bicep Outdated Show resolved Hide resolved
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a few small items, but nothing blocking.

.gitignore Outdated Show resolved Hide resolved
static-content-hosting/README.md Outdated Show resolved Hide resolved
static-content-hosting/src/index.html Outdated Show resolved Hide resolved
@ferantivero ferantivero force-pushed the feature/205203_static-content-refresh branch from 6a31de6 to 555fccb Compare May 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants