WebGPURenderer: Optimize and reuse varyings #28210
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGPU is currently limited to 16 varyings, which can be quickly exceeded with the node system, leading to errors such as:
This PR sets up the naming of varyings where possible in order to reuse them, thereby enhancing performance and enabling debugging.
Before this PR with a fairly advanced setup:
After this PR, on the same program:
The only issue I encountered while working on this was my inability to assign the
v_normalLocal
name tonormalLocal
. /cc @sunag. Otherwise, everything seems to function well, even in complex setups.This contribution is funded by Utsubo