Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few updates #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Few updates #2

wants to merge 7 commits into from

Conversation

joshghent
Copy link

@joshghent joshghent commented May 8, 2019

Great project! Thanks for this! Works like a dream 👍

I've added a few changes, listed below:

  • Added a new SLACK_EMOJI config option to change the slack emoji
  • Changed the default emoji to 🎵
  • Updated the README with clearer setup instructions
  • Added emoji detection. e.g., if the song or artist name contains "leaves" it will use the 🍃 emoji in the slack status (occasionally gives some false positives but we can improve on this)
  • Added auto restart functionality if the last.fm api fails
  • Check if the track is playing before updating the status. If the track is not playing then we will update the status saying that nothing is playing.

@joshghent
Copy link
Author

Added auto restart functionality. If you've got a moment, it would be great to get this merged in.
If you have no interest in the project anymore (understandable, I've got a graveyard of personal projects myself), then I am happy to take over ownership of it 👍

@joshghent
Copy link
Author

Added docker support 👍

@delete-merged-branch delete-merged-branch bot deleted the edit-status branch May 14, 2019 09:47
@joshghent joshghent mentioned this pull request May 14, 2019
@owenvoke
Copy link

I'd say that Docker support would make more sense in a separate PR.

@joshghent
Copy link
Author

joshghent commented Jul 17, 2019

@owenvoke ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants