Skip to content
This repository has been archived by the owner on Jul 31, 2019. It is now read-only.

Add 'My Projects' link in the header for logged-in users - Issue 2533 #2540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'My Projects' link in the header for logged-in users - Issue 2533 #2540

wants to merge 1 commit into from

Conversation

brianhall
Copy link

Closes: #2533

This PR adds a "My Projects" link to the header for a logged-in user, allowing quick access to their projects.

Feedback welcome!

@brianhall brianhall changed the title Add 'My Projects' link in the header for logged-in users. Add 'My Projects' link in the header for logged-in users - Issue 2533 Oct 24, 2017
@gideonthomas gideonthomas self-requested a review November 3, 2017 18:30
@gideonthomas
Copy link
Contributor

@brianhall, this works great! Thanks for the patch. I'm going to hold of on approval until I clarify the text that should show up. @flukeout, should the text be "My Projects" or should it be the same as what we have in the user dropdown menu - "Your Projects"?

@flukeout
Copy link
Contributor

Reviewing now!

@flukeout
Copy link
Contributor

flukeout commented Nov 13, 2017

Hey this is really great. I'd recommend putting the Your Projects link next to the User dropdown, like this, however...

image

My reasoning is that that's where the user is acting and seeing changes, so they are more likely to notice it. Mixing it into the main site navigation makes it harder to notice and connect mentally to the User's account stuff, which is all in the top right. We can adjust spacing around the items it if feels like we've got too much stuff in the top bar.

Thanks for getting this change started @brianhall. I think it will be very useful 👍

@flukeout
Copy link
Contributor

flukeout commented Dec 1, 2017

Hey @brianhall—do you think you will have a chance to make change I requested in this PR? Let me know. If not, we can take over and finish the work as well. Cheers!

@brianhall
Copy link
Author

Hi @flukeout! No problem, I'd like to get it fixed up. May take another day or two, but I'll submit the requested changes. 👍

@flukeout
Copy link
Contributor

flukeout commented Dec 4, 2017

No worries @brianhall—thanks for the update!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants