Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified ssh config declaration and handling #677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soraxas
Copy link

@soraxas soraxas commented Jan 2, 2024

This PR pretty much unified the location of declaring all SSH config value that are simply passthrough.

This is achieved by reflection on struct field name and its datatype, plus custom struct tag to denote how to handle some of the range fields.

So that when there are new ssh config value, you only need to add a new line accordingly in the struct Host {...}

@soraxas soraxas requested a review from moul as a code owner January 2, 2024 02:30
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 2, 2024
@soraxas soraxas force-pushed the feat-unified-ssh-conf branch 2 times, most recently from a1b8200 to fc322a8 Compare January 2, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant