Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: delete netpoll mode #2156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

taoyuanyuan
Copy link
Contributor

Issues associated with this PR

Your PR should present related issues you want to solve.

Solutions

You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.

UT result

Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.

Benchmark

If your code involves the processing of every request, you should give the Benchmark Result.

Code Style

  • Make sure Goimports has run
  • Show Golint result

@taoyuanyuan taoyuanyuan changed the title delete netpoll mode change: delete netpoll mode Oct 28, 2022
@taoyuanyuan taoyuanyuan added this to the 1.3.0 milestone Oct 28, 2022
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 60.33% // Head: 60.58% // Increases project coverage by +0.25% 🎉

Coverage data is based on head (f2b9a35) compared to base (d2f891a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2156      +/-   ##
==========================================
+ Coverage   60.33%   60.58%   +0.25%     
==========================================
  Files         417      416       -1     
  Lines       36583    36445     -138     
==========================================
+ Hits        22071    22081      +10     
+ Misses      12326    12188     -138     
+ Partials     2186     2176      -10     
Impacted Files Coverage Δ
pkg/config/v2/server.go 64.70% <ø> (ø)
pkg/mtls/crypto/tls/tls_custom.go 40.00% <ø> (ø)
pkg/server/handler.go 40.40% <ø> (+0.79%) ⬆️
pkg/server/server.go 0.00% <ø> (ø)
pkg/network/connection.go 44.99% <100.00%> (+5.60%) ⬆️
pkg/module/http2/transport.go 78.33% <0.00%> (-0.29%) ⬇️
pkg/module/http2/server.go 81.85% <0.00%> (+0.21%) ⬆️
pkg/stream/xprotocol/conn.go 41.53% <0.00%> (+1.09%) ⬆️
pkg/upstream/servicediscovery/dubbod/bootstrap.go 68.75% <0.00%> (+4.16%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alpha-baby
Copy link
Member

alpha-baby commented Oct 30, 2022

这是要移除 easygo ?
是考虑到上了 MOE 后 easygo 意义不大,所以才要移除?

@taoyuanyuan
Copy link
Contributor Author

这是要移除 easygo ?
是考虑到上了 MOE 后 easygo 意义不大,所以才要移除?

是的哈,MOE下个版本会开源~

@alpha-baby
Copy link
Member

这是要移除 easygo ?
是考虑到上了 MOE 后 easygo 意义不大,所以才要移除?

是的哈,MOE下个版本会开源~

最好给个压测报告,这样能在公司里面引入 MOE 比较好说服老板。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants